Re: Crash with svn 1.4.0

"Chris AtLee" <chris@atlee.ca> writes:

> I can semi-reliably reproduce a crash with svn 1.4.0 if I interrupt it
> soon after starting a 'svn status' command. It seems to only crash if I
> interrupt it before any output has been generated (while it's locking
> the wc?) My working copy is fairly large (a few hundred megs), so there
> is often a few seconds before any status information is output. It runs
> clean under valgrind except for an "Invalid read of size 4" at
> apr_hash.c:117, which isn't too surprising.

I can reproduce this using this patch:

Index: subversion/svn/main.c
===================================================================
--- subversion/svn/main.c (revision 21766)
+++ subversion/svn/main.c (working copy)
@@ -853,7 +853,8 @@
 svn_error_t *
 svn_cl__check_cancel(void *baton)
 {
- if (cancelled)
+ static int dbg = 8;
+ if (cancelled || ! --dbg)
     return svn_error_create(SVN_ERR_CANCELLED, NULL, _("Caught signal"));
   else
     return SVN_NO_ERROR;

and this working copy:

$ rm -rf repo wc
$ svnadmin create repo
$ svn co file://`pwd`/repo wc
$ svn mkdir wc/a wc/a/a wc/a/b
$ svn st wc
../svn/subversion/svn/main.c:858: (apr_err=200015)
svn: Caught signal
Segmentation fault

Reverting r19196, the non-recursive closing stuff, stops the crash.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org