[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: New svn_path_is_root "X:" stuff makes Subversion sslllooowww

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2006-09-27 18:35:59 CEST

"Erik Huelsmann" <ehuels@gmail.com> writes:

> Well, we could put all those is_canonical calls behind a compiler
> conditional SVN_DEBUG_PATH_API or something like it. Even normal debug
> builds won't include that code if we do that. You hinted yourself at
> removal of is_canonical when the pool creation was discussed.

Would anyone enable it? I don't think I would, it's too expensive.

> There are probably some calls remaining where there is no pool in a
> public api which is now calling the path_is_root functions. I have
> suggested we create new api functions for those which need a pool and
> deprecate the ones without a pool parameter.

That would still leave the UTF8 stuff, I suspect it would still be
expensive.

> Instead of forwarding the
> old api calls to the new api, we could leave in the broken code,
> fixing only clients which are updated to the new api (but keeping the
> old performance in all cases).

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 27 18:36:21 2006

This is an archived mail posted to the Subversion Dev mailing list.