[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add property handling to mailer.py's commit messages

From: Alan Barrett <apb_at_cequrux.com>
Date: 2006-09-25 11:05:18 CEST

On Mon, 25 Sep 2006, Mathias Weinert wrote:
> New configuration parameters:
> show_props configure which property changes to report
> (valid options are any combination of
> 'add copy modify delete')
> show_props_svn configure whether 'svn:' properties shall
> also be reported
> generate_propdiffs configure for which property changes diffs
> shall be created
> (valid options are any combination of
> 'add copy modify delete')
> generate_propdiffs_svn configure whether diffs for 'svn:' properties
> shall also be reported

Separating properties into "svn:*" and "others" seems too restrictive.
What if somebody wants to ignore the svnmerge-integrated property, or
ignore svn:mergeinfo while not ignoring svn:executable? I suggest using
a regular expression to decide which properties to ignore.

> +# Meaning of the possible values:
> +# add: lists all added properties including the ones added for
> +# newly added paths
> +# copy: lists all properties which were implicitly added by making
> +# a copy of a path and not changed or removed after copying
> +# modify: lists all modified properties, including the ones that were
> +# added by making a copy of a path and modified afterwards
> +# (within the same commit)
> +# delete: lists all removed properties including the ones for removed
> +# paths
> +show_props = add copy modify

I'd like a way of displaying diffs for deleted properties, but not
displaying anything about properties for a deleted path; the fact that
the path was deleted is enough for me.

Perhaps split the "delete" keyword into two keywords with the two
meanings, or perhaps guess which of the two behaviours is wanted from
whether the generate_diffs option contains the "delete" keyword.

--apb (Alan Barrett)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 25 11:06:54 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.