[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r21620 - trunk/build

From: Blair Zajac <blair_at_orcaware.com>
Date: 2006-09-23 01:32:41 CEST

blair@tigris.org wrote:
> Author: blair
> Date: Fri Sep 22 16:29:27 2006
> New Revision: 21620
>
> Log:
> * build/run_tests.py
> (_run_test):
> Move code common to two branches in a if test outside the if test.
>
>
> Modified:
> trunk/build/run_tests.py
>
> Modified: trunk/build/run_tests.py
> URL: http://svn.collab.net/viewvc/svn/trunk/build/run_tests.py?pathrev=21620&r1=21619&r2=21620
> ==============================================================================
> --- trunk/build/run_tests.py (original)
> +++ trunk/build/run_tests.py Fri Sep 22 16:29:27 2006
> @@ -94,28 +94,23 @@
> progname = sys.executable
> cmdline = [quote(progname),
> quote(os.path.join(self.srcdir, prog))]
> - if self.verbose is not None:
> - cmdline.append('--verbose')
> - if self.cleanup is not None:
> - cmdline.append('--cleanup')
> if self.base_url is not None:
> cmdline.append(quote('--url=' + self.base_url))
> - if self.fs_type is not None:
> - cmdline.append(quote('--fs-type=' + self.fs_type))
> elif os.access(prog, os.X_OK):
> progname = './' + progbase
> cmdline = [quote(progname),
> quote('--srcdir=' + os.path.join(self.srcdir, progdir))]
> - if self.verbose is not None:
> - cmdline.append('--verbose')
> - if self.cleanup is not None:
> - cmdline.append('--cleanup')
> - if self.fs_type is not None:
> - cmdline.append(quote('--fs-type=' + self.fs_type))
> else:
> print 'Don\'t know what to do about ' + progbase
> sys.exit(1)
>
> + if self.verbose is not None:
> + cmdline.append('--verbose')
> + if self.cleanup is not None:
> + cmdline.append('--cleanup')
> + if self.fs_type is not None:
> + cmdline.append(quote('--fs-type=' + self.fs_type))
> +

I did this minor cleanup, but does anybody know why one branch of the above test
has the following code while the other doesn't?

         if self.base_url is not None:
           cmdline.append(quote('--url=' + self.base_url))

Regards,
Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Sep 23 01:33:12 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.