[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r21554 - in trunk/subversion: include libsvn_ra_svn libsvn_repos svnserve

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-09-19 19:04:12 CEST

On 9/19/06, Garrett Rooney <rooneg@electricjellyfish.net> wrote:
> On 9/19/06, Philip Martin <philip@codematters.co.uk> wrote:
>
> > That looks odd, it makes svnserve a privileged user of libsvn_ra_svn
> > and the dependency is not obvious when looking at the ra_svn code.
> > Could the relevant declarations be moved to "include/svn_ra_svn.h", or
> > failing that could the file be moved to "private/svn_sasl.h"?
>
> I'd hate to put it in svn_ra_svn.h, since it's not really public
> interfaces at all (of course, if I had my way svn_ra_svn.h would be
> private anyway, and there would be no issue...), but I see no problem
> with putting it in private, so I'll look at making that change.

Ok, one catch... ra_svn_sasl.h depends on ra_svn.h for one constant
(SVN_RA_SVN__READBUF_SIZE). Now there's no way in hell that
SVN_RA_SVN__READBUF_SIZE should live in ra_svn_sasl.h, and similarly,
I'm not all that thrilled about ra_svn.h living in private/, since
it's really not used outside of libsvn_ra_svn. Any thoughts on a
proper home for that constant?

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 19 19:04:40 2006

This is an archived mail posted to the Subversion Dev mailing list.