[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Show more information in diff labels in mailer.py

From: Mathias Weinert <wein_at_mccw.de>
Date: 2006-09-18 10:21:23 CEST

Peter Samuelson wrote:
> [Mathias Weinert]
> > On cygwin (patch 2.5.8) copied files didn't work (see above) and
> > deleted files result in a 0 byte file. It's all the same behaviour
> > compared to today's diff format.
>
> GNU patch, on Unix, will delete a file in two cases:
>
> The +++ file has a timestamp of (time_t)0. This will look something
> like "1969-12-31 18:00:00.000000000 -0600".
> or
> The +++ file is named "/dev/null".
>
> I think it's useful to do at least one of those things.

Thanks for the hint. I can confirm this behaviour on cygwin whereas on
my Solaris machine neither variant works (always ending with a 0 bytes
file). And I agree to you that it's useful to use at least one of the
two variants. As the second one doesn't make it obvious that the file
is missing (on the first sight there is a "normal" path). I suggest to
use the following header for deleted files:

--- file1 r5 Sun Sep 9 15:40:00 2001 (original)
+++ () 00:00:00 1970 (empty, because file is deleted)

Could you please confirm that this works with your GNU patch?

Mathias

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 18 10:21:48 2006

This is an archived mail posted to the Subversion Dev mailing list.