[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: WC entries with copyfrom URL/rev but not copied?

From: Ivan Zhakov <chemodax_at_gmail.com>
Date: 2006-09-15 14:58:43 CEST

On 9/11/06, Malcolm Rowe <malcolm-svn-dev@farside.org.uk> wrote:
> I notice that I've got some entries in my newly-upgraded 1.4 WC's that
> have non-blank ->copyfrom_url and ->copyfrom_rev values, but also have
> ->copied set to FALSE.
>
> What does that mean? We seem to use ->copied and the copyfrom members
> interchangably - should one imply the other?
>
> If it's any help, I think I may have switched the directory between
> a local trunk and a tag (which would have been copied-from a branch)
> and back again. One of the child directories now has the branch as
> copyfrom, even though it's no longer switched to the tag. There are no
> local modifications in the wc.
>
>
> Would it be appropriate to add some code to read_entry() to force
> copyfrom_* to empty if copied is FALSE? (and error if copied is TRUE
> and copyfrom_* is empty?)
Yes, you are right. It's a bug and it should be fixed. But
read_entry() is not appropriate place for do this, because this
copyfrom_url/copyfrom_rev should be fixed before writing entries to
the disk. So for me right place for fix this bug is fold_entry().

-- 
Ivan Zhakov
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 15 14:58:54 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.