[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH][merge-tracking] libsvn_fs_util

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: 2006-09-14 11:23:06 CEST

> The get_merge_info() interface is used by svn_fs_get_merge_info(),
> which is in turn used by svn_repos_fs_get_merge_info(), which is the
> API by which we retrieve merge info for use on the client-side. It or
> an equivalent API is absolutely necessary.
>
>

Now svn_fs_get_merge_info() calls 'svn_fs_util_get_merge_info' directly
instead of vtable hooks as I felt mergeinfo indexing is independent of
'fs backend' and only sqlite based.
Now I found to be wrong in this. I would make vtable based.

>> Do we have any plans to have different 'mergeinfo' stores for each repo
>> backend type? Then I agree this need to be part of individual backend.
>> If we have different type of backend 'mergeinfo' store for each repo
>> type then most of this exercise is not needed and sqlite related stuff
>> could be left in libsvn_fs_fs itself.
>>
>
> I see no reason to unnecessarily dictate the type of merge info index
> used by a backend. Encapsulating the storage type inside the FS
> backend module adds very little overhead.
>
>
Then I see no meaning in the existence of libsvn_fs_util(Which I believe
is meant to hold the reusable sqlite code.)
Correct me if I am missing something.

With regards
Kamesh Jayachandran

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 14 11:22:53 2006

This is an archived mail posted to the Subversion Dev mailing list.