Re: Spuriously failing hook scripts

On 9/13/06, Malcolm Rowe <malcolm-svn-dev@farside.org.uk> wrote:
> On Wed, Sep 13, 2006 at 10:20:27AM +0100, Malcolm Rowe wrote:
> > We should definitely fix the error-reporting problem. It's probably
> > sufficient to change 'if (APR_STATUS_IS_CHILD_NOTDONE(apr_err)' to 'if
> > (!APR_STATUS_IS_CHILD_DONE(apr_err))' - most likely we didn't expect
> > to receive any other errors than APR_CHILD_DONE - the APR documentation
> > doesn't mention that any others are possible, though both Unix and Win32
> > implementations can return OS errors).
> >
>
> Something like the below.
>
> Anyone see any reason not to commit this, at least?

Seems reasonable to me.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 13 16:03:29 2006