[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Don't create lock directory in repos if not needed

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2006-09-11 15:23:12 CEST

On Mon, Sep 11, 2006 at 02:18:04PM +0100, Malcolm Rowe wrote:
> (see attached patch)

Er, that'd be this one.

Regards,
Malcolm

Index: subversion/libsvn_repos/repos.c
===================================================================
--- subversion/libsvn_repos/repos.c (revision 21346)
+++ subversion/libsvn_repos/repos.c (working copy)
@@ -261,12 +261,19 @@
 static svn_error_t *
 create_locks(svn_repos_t *repos, apr_pool_t *pool)
 {
- /* Create the locks directory. */
- SVN_ERR_W(create_repos_dir(repos->lock_path, pool),
- _("Creating lock dir"));
+ /* Create the locks directory if necessary. The locks directory is
+ needed on all BDB repositories, and also all backwardly-compatible
+ FSFS repositories, the latter for compatibility with Subversion
+ 1.1 and 1.2. */
+ if (strcmp(repos->fs_type, SVN_FS_TYPE_BDB) == 0 ||
+ repos->format == SVN_REPOS__FORMAT_NUMBER_LEGACY)
+ {
+ SVN_ERR_W(create_repos_dir(repos->lock_path, pool),
+ _("Creating lock dir"));
 
- SVN_ERR(create_db_lock(repos, pool));
- SVN_ERR(create_db_logs_lock(repos, pool));
+ SVN_ERR(create_db_lock(repos, pool));
+ SVN_ERR(create_db_logs_lock(repos, pool));
+ }
 
   return SVN_NO_ERROR;
 }

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 11 15:24:24 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.