Re: [PATCH] add Windows path handling to svn_path functions (issue #1711)

On 9/1/06, Lieven Govaerts <svnlgo@mobsol.be> wrote:

> +svn_boolean_t
> +svn_path_is_absolute(const char *path, apr_size_t len, apr_pool_t *pool)
> +{
> + const char *root_path = NULL;
> + apr_pool_t *strpool = (pool) ? pool : svn_pool_create(NULL);

Since this is a new function, and we don't seem to require the ability
to pass a NULL pool, I'd remove that functionality until it proves
necessary.

Other than that this seems fine to me, +1 to commit.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 6 17:14:05 2006