[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Server-side Cyrus SASL support

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-09-05 23:57:17 CEST

On 9/1/06, Vlad Georgescu <vgeorgescu@gmail.com> wrote:
> On 8/29/06, Garrett Rooney <rooneg@electricjellyfish.net> wrote:
> > On 8/29/06, Vlad Georgescu <vgeorgescu@gmail.com> wrote:
> >
> > > Ouch. I don't know if it's related to the crash or not, but I noticed
> > > I forgot to do any error-checking when calling sasl_init() in main. So
> > > SASL might not have been initialized.
> >
> > That could certainly be an issue.
>
> I figured out why your initialization failed. Turns out that once we
> added those if statements to the mutex callbacks they could no longer
> be used by the server because the server doesn't initialize
> sasl_status (The reason it worked for me when testing those changes is
> that I didn't bother to restart the server after recompiling). So I
> made sasl_status public (see the log message) and changed svnserve's
> sasl_init() to call svn_atomic_init_once().
>
> I also fixed a client-side bug where the value of the 'creds' variable
> wasn't checked as early as it should have been (see the second log
> message).

For what it's worth, I've tried this, and it does indeed stop the
crashing, but I can't seem to get it to actually work. More debugging
later, as I'm still not sure I haven't just screwed something up in my
sasl configuration...

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 5 23:57:51 2006

This is an archived mail posted to the Subversion Dev mailing list.