On Fri, 01 Sep 2006, Peter Samuelson wrote:
>
> [Daniel Rall]
> > > # check if we have a newer neon (0.25.x)
> > > if self.neon_ver >= 25000:
> > > fakedefines.append("SVN_NEON_0_25=1")
> > > + # check for neon 0.26.x or newer
> > > + if self.neon_ver >= 26000:
> > > + fakedefines.append("SVN_NEON_0_26=1")
> >
> > I don't claim to know the intricacies of the 'doze build, but don't
> > we need to do the check for "self.neon_ver >= 26000" first, and put
> > subsequent checks in "else" blocks? Otherwise, we'll be adding
> > multiple elements to fakedefines...
>
> No, multiple defines is correct. Otherwise you need to change all 29
> instances of
>
> #ifdef SVN_NEON_0_25
>
> to the much less readable
>
> #if defined(SVN_NEON_0_25) || defined(SVN_NEON_0_26)
>
> and the same for the 7 #ifndefs.
Okay.
I expected the #defines to have names which actually reflect how
they're used...
- application/pgp-signature attachment: stored
Received on Sat Sep 2 13:36:24 2006