[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r21293 - trunk/build/generator

From: Peter Samuelson <peter_at_p12n.org>
Date: 2006-09-02 06:28:20 CEST

[Daniel Rall]
> > # check if we have a newer neon (0.25.x)
> > if self.neon_ver >= 25000:
> > fakedefines.append("SVN_NEON_0_25=1")
> > + # check for neon 0.26.x or newer
> > + if self.neon_ver >= 26000:
> > + fakedefines.append("SVN_NEON_0_26=1")
>
> I don't claim to know the intricacies of the 'doze build, but don't
> we need to do the check for "self.neon_ver >= 26000" first, and put
> subsequent checks in "else" blocks? Otherwise, we'll be adding
> multiple elements to fakedefines...

No, multiple defines is correct. Otherwise you need to change all 29
instances of

#ifdef SVN_NEON_0_25

to the much less readable

#if defined(SVN_NEON_0_25) || defined(SVN_NEON_0_26)

and the same for the 7 #ifndefs.

Received on Sat Sep 2 06:28:49 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.