[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] recognize replaced paths in mailer.py (needs change in svn/repos.py)

From: Mathias Weinert <mathias.weinert_at_gfa-net.de>
Date: 2006-08-22 13:19:52 CEST

André Malo wrote:
> * Mathias Weinert wrote:
>
> > With the included patch mailer.py will report replaced paths as
> > 'Replaced' and not as 'Added' any more.
> >
> > In order to achieve this I also had to patch
> > subversion/bindings/swig/python/svn/repos.py. Any ideas how to do this
> > in a better way are very welcome.
>
> + replaced = False
> + if self.changes.has_key(path):
> + # if this add is a replace there is already a change record inserted
> + # by a delete, so in this case set replaced to True.
> + replaced = True
>
> =>
>
> # exlpaining comment
> replaced = self.changes.has_key(path)
> # or
> replaced = path in self.changes

Looks better, thanks.

>
> wrt the changes in repos.py: This should be documented in the change log I
> think, as it's an incompatible change.
>

Sorry, but I don't understand what you want to say here. Could you
please explain this to me (what is incompatible with what)? Thanks.

Mathias

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 22 13:20:36 2006

This is an archived mail posted to the Subversion Dev mailing list.