Re: [PATCH] fix for issue #2556: support working copies on the root of a (virtual) drive

> Ok. I didn't investigate more of it myself, so I rely on you to make
> sure that we call svn_path_is_root from other functions which don't
> have a pool (excluding is_canonical, since Philip said we can safely
> remove that function from consideration).

Sorry for reading your patch post so badly. You already addressed that.

There's one more nit: In the patch you say you added X:/ as canonical,
which is true, but by using apr_filepath_root, you also added \\?\X:/,
\\.\.., \\server\share and maybe some others. I've got no idea how to
put it other than 'All forms considered canonical root specs on the
platform at hand, amongst which...' or something like it.

bye,

Erik.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Aug 21 22:33:05 2006