On 8/20/06, Branko Čibej <brane@xbc.nu> wrote:
> Lieven Govaerts wrote:
> > Erik Huelsmann wrote:
> >>
> >> I wouldn't bother with the subpool creation: the extra memory required
> >> is negligeable when compared to other allocated amounts. We generally
> >> don't create subpools for usecases like this.
> >>
> >> (To give you a first review.)
> >
> > I introduced the subpool because I saw suddenly a huge memory usage,
> > which I suspected was due the strings not being cleared from the pool.
> > The problem turned out to be something else though.
> >
> > However, there's another reason why I create a subpool. The function
> > is_canonical (private function in path.c) is calling svn_path_is_root,
> > but that function doesn't have a pool available and is called by other
> > functions which don't have pool parameters.
>
> Eek. That's potentially a big problem, yes; you'd have to use the global
> pool in such calls.
Or, if all of them are private, add a pool parameter...
bye,
Erik.
Received on Sun Aug 20 20:29:42 2006