Lieven Govaerts wrote:
> Erik Huelsmann wrote:
>>
>> I wouldn't bother with the subpool creation: the extra memory required
>> is negligeable when compared to other allocated amounts. We generally
>> don't create subpools for usecases like this.
>>
>> (To give you a first review.)
>
> I introduced the subpool because I saw suddenly a huge memory usage,
> which I suspected was due the strings not being cleared from the pool.
> The problem turned out to be something else though.
>
> However, there's another reason why I create a subpool. The function
> is_canonical (private function in path.c) is calling svn_path_is_root,
> but that function doesn't have a pool available and is called by other
> functions which don't have pool parameters.
Eek. That's potentially a big problem, yes; you'd have to use the global
pool in such calls.
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Aug 20 18:54:47 2006