Re: [PATCH] fix for issue #2556: support working copies on the root of a (virtual) drive

"Lieven Govaerts" <lgo@mobsol.be> writes:

> Prepare fix for issue #2556: abstract root folder checks in
> svn_path_is_root.
> Add support for 'X:/' as a root folder on Windows.

Grepping for \[0\].*\'/\' shows that there might be a few places where
we assume that path[0]=='/' is special; I don't know whether your
patch invalidates those assumptions. If path is a Subversion FS path
then it's OK but if path is a WC path then it could be a problem. For
example:

- libsvn_client/commit.c:1312 seems to be checking for "/", should it
  be checking for "x:/" as well?

- libsvn_wc/props.c:2110 seems to be checking for "/...", should it be
  checking for "x:/..." as well?

- libsvn_client/diff.c:401 and 408 seem to be checking for "/...",
  should they be checking for "x:/..." as well?

I don't know if these are bugs, and if they are I suspect they are
unrelated to your patch, but someone who groks this Windows stuff
probably ought to take a look :)

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org