RE: [PATCH] fix for issue #2556: support working copies on the root of a (virtual) drive

Thanks for the review Erik.

> -----Original Message-----
> From: Erik Huelsmann [mailto:ehuels@gmail.com]
> Sent: maandag 14 augustus 2006 22:04
>
> > This patch provides two fixes:
>
> In that case, could you provide 2 patches? It's best to
> separate conceptually different changes into separate commits.

Ok, attached you'll find two patches.

> > 1. Introduce 'X:/' as a syntax for a root folder, on Windows.

This change is contained in issue-2556-wc-on-root.patch.txt.

> > 2. Fix an issue where Subversion thinks a working copy on a root path
(both '/' and 'X:/') is switched.

This change is contained in issue-2556-wc-switched.patch.txt.

> Being on holidays (and thus writing this over dail-up), I've
> just skipped over your commit message and not read the actual patch.
> Comment(s) below.

I've used your comments to make two new commit messages.

For issue-2556-wc-on-root.patch.txt:
[[[
Prepare fix for issue #2556: abstract root folder check in svn_path_is_root.

Add support for 'X:/' as a root folder on Windows.

* subversion/include/svn_path.h
  (svn_path_is_root): New function declaration.

* subversion/libsvn_subr/path.c
  (svn_path_is_root): New function. Tests for either '/' on all platforms
   or 'X:/' on Windows.
  (is_canonical): 'X:/' syntax on Windows is canonical.
  (svn_path_join, svn_path_dirname, svn_path_basename): Support the new type

   of root path on Windows, mostly by replacing direct comparisons of path
   and '/' with a call to svn_path_is_root.
  (svn_path_canonicalize): don't strip the trailing slash if the path is
   of the 'X:/' syntax.

* subversion/tests/cmdline/update_tests.py
  (update_wc_on_windows_drive): New test for issue 2556.
  (test_list): add the new test to the list.
]]]

For issue-2556-wc-switched.patch.txt:
[[[
Fix an issue where the status of a working copy on the root of a drive is
'S' (switched), as part of issue #2556.
This is not Windows specific, this code didn't work for working copies on
'/' either.

* subversion/libsvn_wc/status.c
  (assemble_status): add support for working copies at the root of a
(virtual)
   drive.
]]]

regards,

Lieven.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org