[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: atomic revprop commits at the RA level

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2006-08-14 21:59:09 CEST

Garrett Rooney wrote:
> On 8/14/06, David Glasser <glasser@mit.edu> wrote:
>> * Should change_edit_props be allowed before open_root? If not, then
>> we definitely need to make the change to r(epos|a)_replay. If so, some
>> code in repos and ra_serf will have to be changed to do some
>> initialization in get_commit_editor instead of in open_root (or to
>> cache edit prop changes until open_root); I'm not sure why those
>> editors choose to wait until open_root to really start things, and if
>> it's important behavior to preserve.
>
> ENOCLUE here.

Yes, change_edit_props should be allowed before open_root(). This doesn't
mean, of course, that the commit editors which currently delay this action
until open_root() must now create the transaction at editor-creation time --
they can just delay it until either of open_root() or change_edit_props()
occurs.

One additional thing to watch for is that we don't make it super-easy for
folks to commit revisions that have no tree changes, just property mods.
Not sure what the best mechanism for doing so is, though.

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Mon Aug 14 22:00:03 2006

This is an archived mail posted to the Subversion Dev mailing list.