Re: Bad property name

On 8/8/06, C. Michael Pilato <cmpilato@collab.net> wrote:
> C. Michael Pilato wrote:
> >>2. Why does it not check the property name before starting the editor?
> >
> > Hrm. Now there's a good question. I'd call that a bug.
>
> Aha. The is-valid check happens down in libsvn_client, well after the
> editor has been used to get a property value. I think we should expose the
> is_valid_propname (and similar) checks through the svn_client.h API, and
> teach the command-line client to use them before firing up the editor.

Out of curiousity, is it intentional that propname validity checking
happens at the svn_client level and not at a lower level?

I was actually considering sending a message about a similar issue
just this week, after discovering a bug in svk where it misparsed the
auto-props configuration section and silently set properties with
names like " svn:eol-style" (with a leading space). Having any "valid
property name" API at all would be great, but does it make sense to
allow weird property names at the repository level? (I guess you have
to for compatibility reasons now.)

--dave

-- 
David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org