Re: [PATCH] Refactor the bdb atomic initialization code into a generic implementation

Branko Èibej <brane@xbc.nu> writes:

> Vlad Georgescu wrote:
>> (BDB_CACHE_UNINITIALIZED,
>> BDB_CACHE_START_INIT,
>> BDB_CACHE_INIT_FAILED,
>> BDB_CACHE_INITIALIZED): Deleted. Similar definitions are now in
>> svn_atomic.h.
> I cannot for the life of me imagine why these definitions should be part
> of Subversion's public API. In fact, they shouldn't be. They should
> either go into svn_private_config.h, or, if that's not appropriate
> (being a generated header), we should introduce a new _private_ header
> for them.
>
> -1 on putting them in include/svn_atomic.h, they have no use outside the
> library implementation.

We don't need all four values, but the public API does need to provide
a mechanism to initialize static objects of type svn_atomic_t so some
sort of SVN_ATOMIC_ONCE_INITIALIZER is needed, unless we document that
a static zero initialisation is sufficient.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org