Bhuvaneswaran Arumugam wrote:
>> +# TODO:
>> +# --item-url should support arbitrary formatting of the revision number,
>> +# to be useful with web viewers other than ViewVC.
>> +# Actual commit date information should be placed into the feed metadata,
>> +# not the item bodies.
>> +# Actual commit author information should be placed into the feed metadata,
>> +# not the item bodies.
>
> The above TODO items are bit unclear (atleast for me). IMO, it would be
> precise to make them as follows:
>
> --item-url should support arbitrary formatting of the revision number.
> It will be useful with web viewers other than ViewVC.
Sorry, but no: your version sounds a bit weird to native English
speakers. It is less precise, as no logical connection between the
proposal and justification is expressed.
> Actual commit date information should be placed into the feed metadata
> instead of item summary.
> Actual commit author information should be placed into the feed metadata
> instead of item summary.
Better than both my previous, and yours, would be:
Actual commit XXX information should be placed into the _item_ metadata
instead of _the_ item _summaries_.
>> +# Rather more than intended is being cached in the pickle file. Instead of
>> +# only old items being drawn from the pickle, all the global feed metadata
>> +# is actually set only on initial feed creation, and thereafter simply
>> +# re-used from the pickle each time.
>
> If i get it correct, you mean to say that we *should not* store the
> global feed metadata (all tags except "entry") in the pickle file? If
> no, please elaborate.
Correct. Well, we can store them, since that gives us a single root
object to pickle, which is more convenient. However, the important thing
is for the script to replace them with an up-to-date version when
reloading the pickle.
One specific bug arising from the current behaviour is that the feed's
<updated> element is never updated - it keeps the value it is given when
the pickle was first created.
Max.
Received on Sat Aug 5 21:21:14 2006