Re: svn commit: r20991 - trunk/contrib/hook-scripts

> - if(childNode.nodeName == 'author'):
> - self.feed.insertBefore(item, childNode.nextSibling)
> - elif(childNode.nodeName == 'entry'):
> + if childNode.nodeName == 'entry':
> + if total == 0:
> + self.feed.insertBefore(item, childNode)
> + total += 1
> total += 1

Weird! We increment the "total" twice when the value is 0. Result: We
manage to store max_items-1 items in the feed file. I bet, you intend to
remove the increment statement which resides inside the "if total == 0:"
loop :)

> -- if (total > self.max_items):
> - self.feed.removeChild(self.feed.lastChild)
> + if total > self.max_items:
> + self.feed.removeChild(childNode)

Here again, why do we wish to include the above "if" condition for every
childNode ? We call this function for every revision, so it's good to
place it outside the "for" loop. Moreover, in the current state it'll
not remove multiple nodes (if you intend to), since we increment the
"total" one at a time.

-- 
Regards,
Bhuvaneswaran