Re: [PATCH] Multiple WC copies/moves without intervening ci

rooneg@gmail.com wrote on 07/18/2006 02:37:10 PM:

> In general this stuff looks good, just a few little tweaks. First,
> there were some warnings in the copy code because
> get_copyfrom_url_rev_via_parent takes a const char **, but the
> copyfrom_url variable is non-const. I made it const, and that gave us
> problems because svn_wc_get_ancestry expects a non-const pointer, so I
> used a temp variable for that...
>
> Also, test 45 in copy_tests.py had a spurious raise svntest.Failure,
> removed that and the tests passed fine.

Ouch, how embarassing :-\
 
> Here's an updated patch.
>
> -garrett

"Ivan Zhakov" <chemodax@gmail.com> wrote on 07/19/2006 04:31:50 AM:

> >
> Looks good, I'm +1 for commit. Thanks Paul for finishing this!
>
> --
> Ivan Zhakov

Thanks Ivan for the starting patch and Garrett for the refinements.

Committed r20811

Paul B.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 21 00:12:02 2006