Re: [PATCH] Atom 1.0 feeds for subversion
From: Bhuvaneswaran Arumugam <bhuvan_at_collab.net>
Date: 2006-07-19 12:49:22 CEST
Malcolm, Thanks for your review!
> * The usage message could be a lot clearer. I couldn't determine what
Ok. I have added the enough document to such messages.
> * The output Atom file declares the XHTML namespace, but doesn't use it.
Yeah, you are correct. Henceforth i don't declare the XHTML namespace.
> * There's a fair bit of unnecessary trailing whitespace in the file.
I have corrected them.
> In my testing, the script generated a file called '.atom', not
I'm unable to repeat this issue. Can you please provide the test case ?
> The generated URL for each item is ITEM_URL?rev=N. That's a bit odd
Yes, i've now documented.
> Atom feeds require both a feed URL and item URL - or perhaps you can drop
The feed URL and item URL are required in the Atom feed. The domain part
> * The generated feeds don't pass the feed validator, since they lack an
Yeah, you are correct. But i guess, it is just a warning message.
> Finally, I needed to apply the attached patch to get this to work
Thanks for the patch. I've incorporated it in my patch.
 http://www.atomenabled.org/developers/syndication/#link , Atom
-- Regards, Bhuvaneswaran
This is an archived mail posted to the Subversion Dev mailing list.