Re: [PATCH] Fill in callbacks for svn_ra_callbacks2_t()

On 7/5/06, Jelmer Vernooij <jelmer@samba.org> wrote:
> > Ah, OK. Jelmer, could you provide some example test scripts which use
> > these functions so that I can test them myself?
> I've attached an example script that does a checkout, which crashes
> without this patch.
Thanks!

> I've attached a patch that contains the subset of functions that are
> proven to work now using the attached example script.
>
> [[[
> Allow some callbacks in svn_ra_callbacks2_t() to be implemented in
> Python.
>
> * subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
>
> (svn_swig_py_setup_ra_callbacks): Fill in callback function pointer
> for open_tmp_file and auth_baton.
>
> (ra_callbacks_open_tmp_file): Add wrapper for Python callbacks
>
> ]]]

+1. Thanks for following up! This is a nice patch. Could you reference
this thread from your commit message? Mention that you included a test
script in this mail thread, so that anybody who is interested can add
a real test later.

The mail thread URL is
http://svn.haxx.se/dev/archive-2006-07/0126.shtml and your test-dav.py
is accessible from that URL.

Cheers,

David

-- 
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org