[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Re: [PATCH] Sensible tests for "svn --help" and "svn help" commands

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2006-06-30 12:37:05 CEST

On Fri, 30 Jun 2006 14:44:57 +0530, Bhuvaneswaran Arumugam
<bhuvan@collab.net> wrote:

>
>> > * getopt_tests.py
>> > (getopt__help): Call run__help_test and we no more use
>> run_one_test
>> > (getopt_help): Call run_help_test and we no more use run_one_test
>>
>> Why two functions, when one can do?
>
> Currently, for each command we call separate function. They in turn call
> a unique function, thus it adds more clarity to the code. I have done
> changes to stay in line with this standard.

svn help and svn --help are not two different commands. Anyways, how do
they add clarity to the code? I think it only adds overhead to test
execution.

Moreover, consider the other mail I sent :
> (run__help_test): New function. Match the defined lines and raise
> svntest.Failure if all the lines dont match
> (run_help_test): New function. Call run__help_test since both of
> them does exactly the same

Theres definitely no need to either have these two functions.

Regards,
Madan.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 30 12:07:07 2006

This is an archived mail posted to the Subversion Dev mailing list.