Re: [PATCH] Support svn.ra.get_file_revs()

On 6/17/06, Jelmer Vernooij <jelmer@samba.org> wrote:
> [[[
> Fix Python bindings for svn.ra.get_file_revs().
>
> * subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.[ch]
> (svn_swig_py_ra_file_rev_handler_func): Add Python wrapper for
> svn_ra_file_rev_handler_t.
> * subversion/bindings/swig/python/tests/ra.py
> (test_get_file_revs): Add test for svn.ra.get_file_revs()
> ]]]

Great work, Jelmer! I read through this patch carefully, and
everything looks quite good except for a few small details. I
especially appreciate your attention to detail in using Py_XDECREF for
py_rev_props and py_prop_diffs, which might be NULL.

Some details to fix:
1) We need to create a new function 'proparray_to_list' to convert an
array of svn_prop_t * items into a Python list. You used
svn_swig_py_array_to_list to do the job, but it won't work.
2) In svn_swig_py_ra_file_rev_handler_func, we should pass in
py_prop_diffs to the callback function instead of the regular
"prop_diffs". (prop_diffs is not a Python object.)
3) In ra.py, we should check the value of "prop_diffs" to make sure it
is correct.

Once these issues are fixed, this is ready to commit, I think.

Cheers,

David

-- 
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org