Garrett Rooney wrote:
> On 6/13/06, Madan U Sreenivasan <madan@collab.net> wrote:
>
>> Do you think such a long comment is required here? The reason is anyways
>> explained in the log...Also I think this will confuse the reader, as to
>> why such a long comment was deemed necessary.
>>
>> Not a big deal... just my two cents worth :)
>
> The long comment is there because it's incredibly weird and
> nonintuitive that we should have to destroy that pool in order for
> things to work, and incredibly weird things should be documented in
> the code, not just in a commit log.
I absolutely agree about that comment being necessary.
> Of course, Branko is working on a fix to make that pool destruction
> entirely unnecessary, but if it was going to live on in the code the
> comment would be appropriate ;-)
Heh, I promise to rip out the comment as soon as the pool dsctruction
becomes unnecessary.
I'll dent a few walls hitting them with my head first, though ...
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 14 08:08:16 2006