[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Python tests fail on filenames with $ signs on non-windows platforms

From: Lieven Govaerts <lgo_at_mobsol.be>
Date: 2006-06-10 17:20:03 CEST

Hi,

in r20036 I introduced a new python test, to validate the correct behaviour
of keyword (un)expansion on filenames containing $ signs.

The test works fine on Windows, but when running on linux and mac
buildslaves it fails.

I see in svntest/main.py that all command-line arguments for svn are wrapped
in double quotes, like this:
CMD: svn.exe "add" "svn-test-work\working_copies\trans_tests-1\id_exp
with_$_sign" "--config-dir"
"C:\devel\subversion\trunk\Debug\subversion\tests\cmdline\svn-test-work\loca
l_tmp\config"

On windows that works fine, but on linux/mac the $_sign will be recognized
as variable and be replaced.

I see two possible solutions:
1. On non-windows platforms, replace all $ signs with \$. Attached patch
will do that.
2. On non-windows platforms, use single-quotes instead of double quotes to
wrap the arguments.

While at first sight both solutions seem to work, I just want to make sure
that it will work on any platform Subversion support.

Input anyone?

regards,

Lieven.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Sat Jun 10 17:24:57 2006

This is an archived mail posted to the Subversion Dev mailing list.