On 5/31/06, David James <djames@collab.net> wrote:
> Nice patch, Vlad! I have a few suggestions on how we can improve this patch:
> - If the user does not supply a --with-sasl option, we should look
> in the standard locations for the SASL library (e.g. /usr,
> /usr/local). If SASL is found, we should use it.
> - If the user supplies a --with-sasl option, but does not specify a
> directory, we should look in the standard locations (e.g. /usr,
> /usr/local).
> - If the user supplies a --with-sasl option, and SASL is not found,
> configure should abort with an error message.
>
> Also, I found a few tab characters in your patch. Please replace these
> characters with spaces.
>
> Other than these minor issues, your patch looks excellent. Keep up the
> good work -- I'm looking forward to the next version of your patch!
>
> Cheers,
>
> David
I attached a revised version of the M4 file. Let me know what you think.
I'd also like some feedback on the following idea:
I'm thinking of extracting the authentication-related functions from
libsvn_ra_svn/client.c, putting them in another file, and then
creating a new file with the same interface that does authentication
through SASL. I would then conditionally compile & link only one of
those files depending on whether or not SASL is present on the system.
Does something like this make sense?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jun 3 21:45:31 2006