Re: [PATCH] Remove ugly duplication of directories searched for include files

Hi,

In <20060526.020135.07644983.nori1@dolphin.c.u-tokyo.ac.jp>
  "[PATCH] Remove ugly duplication of directories searched for include files" on Fri, 26 May 2006 02:01:35 +0900 (JST),
  Kobayashi Noritada <nori1@dolphin.c.u-tokyo.ac.jp> wrote:

> In the Makefile for Subversion, some directories searched for include files
> are specified redundantly, since...:
>
> * SWIG_PY_INCLUDES includes SWIG_INCLUDES.
> COMPILE_PY_WRAPPER includes both of those two options.
> * SWIG_RB_COMPILE includes SWIG_RB_INCLUDES, which includes SWIG_INCLUDES.
> COMPILE_SWIG_RB includes SWIG_RB_COMPILE and SWIG_RB_INCLUDES, and
> COMPILE_RB_WRAPPER includes SWIG_RB_COMPILE, SWIG_INCLUDES, and
> SWIG_RB_INCLUDES.
>
> Actually, when I run
> 'make -W subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c
> -n subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.lo',
> I find 28 '-I'-s in the resulting one line and the 80x20 terminal screen is
> filled with that line... :-)
> It may not be harmful but is ugly.
> Here is a patch to fix it.
> Please check it.

+1 for the Ruby bindings.
Thank you for your works, nori!

Regards,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org