[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Improving support for copy and move

From: Paul Burba <paulb_at_softlanding.com>
Date: 2006-05-25 17:47:33 CEST

"Ivan Zhakov" <chemodax@gmail.com> wrote on 05/25/2006 08:39:40 AM:

> On 5/25/06, Paul Burba <paulb@softlanding.com> wrote:
> > "Ivan Zhakov" <chemodax@gmail.com> wrote on 05/25/2006 05:25:24 AM:
> > > Paul, thanks for tests! I am looking to situation, it seems design
> > > problem. I am going to send another email about it.
> > >
> > > --
> > > Ivan Zhakov
> >
> > Ivan,
> >
> > Just in case you missed it, Garrett had some helpful changes to my
this
> > patch. I'll have another one ready shortly based on his ideas, with
some
> > additional/improved tests as well. Sorry for the delay, I've been
spread
> > thin the last few days.
> >
> Yes, I've seen Garett's changes, but I'm not sure that it's right way
> to fix problem.

Ivan,

Ok, I'll leave this back in your hands.

My latest patch is attached, it has some changes to the Python tests which
may prove useful:

move_file_within_moved_dir - Now moves a file in a subdirectory of the
moved directory rather than within the root of the initial moved
directory:

  Old move_file_within_moved_dir
    mv A/B/E A/B/F/E_moved
    mv A/B/F/E_moved/alpha A/B/F/E_moved/alpha_moved
    mv A/B/F/E_moved/alpha_moved A/B/F/E_moved/alpha_moved_again

  New move_file_within_moved_dir
    mv A/B/D A/B/F/D_moved
    mv A/B/F/D_moved/H/chi A/B/F/D_moved/H/chi_moved
    mv A/B/F/D_moved/H/chi_moved A/B/F/D_moved/H/chi_moved_again

move_file_out_of_moved_dir - New test similar to
move_dir_within_moved_dir, but the last move is out of the initial moved
dir entirely:

    mv A/B/D A/B/F/D_moved
    mvA/B/F/D_moved/H/chi A/B/F/D_moved/H/chi_moved
    mv A/B/F/D_moved/H/chi_moved A/C/chi_moved_again

move_dir_out_of_moved_dir - New test similar to
move_file_within_moved_dir, but the last move is out of the initial moved
dir entirely:

  move_dir_within_moved_dir
    mv A/D A/B/D_moved
    mv A/B/D_moved/H A/B/D_moved/H_moved
    mv A/B/D_moved/H_moved A/B/D_moved/H_moved_again

  move_dir_out_of_moved_dir
    mv A/D A/B/F/D_moved
    mv A/B/F/D_moved/H A/B/F/D_moved/H_moved
    mv A/B/F/D_moved/H_moved A/C/H_moved_again

The patch to copy.c is based on Garrett's suggestions, but it's still work
in progress. FWIW, it passes the local and dav tests on XP, including the
new copy ones.

Let me know if there is anything else I can do.
 
Paul B.

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Thu May 25 17:48:23 2006

This is an archived mail posted to the Subversion Dev mailing list.