Re: svn commit: r19803 - in trunk/subversion/bindings/java/javahl: native src/org/tigris/subversion/javahl

On 5/24/06, Daniel Rall <dlr@collab.net> wrote:
> On a related note, here at CollabNet we were wondering if the
> SVNClientInterface.username() and password() Java methods should even
> accept null input, or should instead throw IllegalArgumentException
> [1]. Setting a null username seems like a pretty bogus operation to
> me, setting a null password perhaps less so. Thoughts?

I think we should throw an IllegalArgumentException. If somebody wants
to set an empty password or an empty username, they can do so by
passing the empty string. There's no need to also allow users to pass
in null for this purpose.

Cheers,

David

-- 
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org