Re: [SVNMERGE][PATCH] svnmerge rollback

On Thu, 18 May 2006 00:08:49 +0530, David James <djames@collab.net> wrote:

> On 5/16/06, Madan U Sreenivasan <madan@collab.net> wrote:
>> Implement `svnmerge rollback'.
>> The `rollback' sub-command can be used to rollback previously integrated
>> revisions.
>
> Hi Madan,
>
> This patch looks good except for one small problem in the test suite:
> self.launch("touch newfile")
>
> 'touch' isn't available on Windows. So we should do this instead:
> open("newfile","w").close()

yeah. You are right. Will change this. Thank you for pointing out.

Any other comments, Giovanni, Raman, Mattias?

>
> Other than this issue, the patch looks excellent. I am very impressed
> with the extensive suite of new tests.

Thank you.
>
> Since this is a major new feature, I'd like to wait a few days to see
> if anyone else has feedback before we commit. Giovanni?

Okay. Will wait for Giovanni's nod.

Regards,
Madan.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 17 20:45:18 2006