[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [SVNMERGE][PATCH] handle -r X-Y, where X > Y

From: Giovanni Bajo <rasky_at_develer.com>
Date: 2006-05-16 00:49:08 CEST

Madan U Sreenivasan <madan@collab.net> wrote:
>> [[[
>> Accept -rX-Y, for all svnmerge commands, where X > Y.
>> Before this patch, empty RevisionSet()s were created when X > Y.
>>
>> * contrib/client-side/svnmerge_test.py
>> (TestCase_RevisionSet.test_reverse_order_input_string): New
>> test. Try creating a RevisionSet() with a string range, in
>> descending order.
>>
>> * contrib/client-side/svnmerge.py
>> (RevisionSet.__init__): Sort the input revision range before
>> filling in RevisionSet._revs.
>> ]]]

Rationale? "svn merge" accepts the reversed order with a different semantic
(reversed merge). I'm worried about the confusion that can issue. I am +1 on a
patch that errors out when X > Y until there is agreement on how to best handle
this.

Giovanni Bajo

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 16 00:49:28 2006

This is an archived mail posted to the Subversion Dev mailing list.