[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix python bindings for svn.ra.get_dir2

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-05-11 00:10:53 CEST

On 5/10/06, Jelmer Vernooij <jelmer@samba.org> wrote:
> Hi,
>
> The attached patch fixes the python bindings for svn.ra.get_dir2() and
> svn.ra.get_dir(). Previously these functions would only return the list
> of properties on a directory; it now returns a tupel with a list of
> dirents, revnum that was actually fetched and the list of properties.
>
>
> Changes:
>
> [[[
> * subversion/bindings/swig/svn_ra.i: Mark apr_hash_t **dirents for
> conversion
>
> * subversion/bindings/swig/include/apr.swg: Add typemap for
> apr_hash_t's containing svn_dirent_t structs, allow apr_hash_t's with
> properties to be used in tuples.
>
> ]]]

This builds just fine, but without a test I have no way to know if it
works, and I don't have enough swig-fu to tell via inspection. A few
other points though.

1) Your log messages don't really follow our guidelines. You have
good summaries in your email, but they need to make it into the log
message as well. Also, if you're modifying a file that has well
defined functions, you need to specify which functions are being
modified as part of the message. See how I modified your last patch's
log for details.

2) We don't use tabs in our code, and your indenting should in general
try and match the style of the code around it. This includes trying
to break lines before they hit 80 columns.

Other than that keep up the good work. If you come up with some tests
for this one so I can see that it works I'll be happy to apply,
otherwise I'm sure someone with more swig-fu will come along
eventually.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 11 00:11:21 2006

This is an archived mail posted to the Subversion Dev mailing list.