[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_client_blame3() and svn_opt_revision_working

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2006-05-07 22:40:08 CEST

Stefan Küng writes:
> Peter N. Lundblad wrote:
>
> > > So I think this is either not intended and might be a bug, or the
> > > documentation for svn_client_blame3() should mention that
> > > svn_opt_revision_working blames against the BASE.
> > >
> >
> > I'd say the latter. Does including the local mods give you anything?
>
> > Care to provide a patch for either of the above? :_)
>
> I've tried to understand the blame code by stepping through it in the
> debugger. But I couldn't find where it actually checks for BASE or WC.

That's done in svn_client__get_revision_number, called from
svn_client__ra_session_from_path. That will set end_revnum to the
BASE revision even for WORKING (because there's no revision number for
WORKING, I suppose).

> So a patch from me is not very likely here. Sorry.
>
Someone who wants to do this should check for the kind of the end
revision being working explicitly in svn_client_blame3. Then, after
all
revisions have been received from the repository, just call
add_file_blame once to add blame for the working file. We will need
some API tweaking so that this information can be passed back to the
caller (there's only a revision number). I'd suggest an extra boolean
that's TRUE when we're dealing with the working revision
(SVN_INVALID_REVNUM is already in use for "unknown revision" in this case).

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun May 7 22:40:36 2006

This is an archived mail posted to the Subversion Dev mailing list.