On 4/26/06, Peter N. Lundblad <peter@famlundblad.se> wrote:
> Ivan Zhakov writes:
> > On 4/26/06, Peter N. Lundblad <peter@famlundblad.se> wrote:
> > > Ivan Zhakov writes:
> > > > What do you think about this patch:
> > > > [[
> > > > Remove wcprops directory when upgrade WC to format 8.
> > > >
> > > > * subversion/libsvn_wc/lock.c
> > > > (convert_wcprops): Add log commands to remove wcprops directory and
> > > > dir-wcprops file.
> > >
> > > Couldn't we just remove the directory and file before running the log ignoring
> > > the error? It is no catastrophy if that fails. Same for README and
> > > empty-file.
> > >
> > I dislike such behavior. It's error and we shouldn't silently ignore any error.
>
> My reasoning is that it is so harmless if it happens that actually reporting
> it makes more harm by confusing users, but I'm not really objecting.
>
But if sigfault happens after wcprops directory have deleted we loose
wcprops at all.
Of course I like simpler code, so if we don't fear such situations
I'll do it as you suggesting.
--
Ivan Zhakov
Received on Wed Apr 26 22:09:20 2006