[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: wcprops dir left after upgrading WC

From: Ivan Zhakov <chemodax_at_gmail.com>
Date: 2006-04-26 14:14:50 CEST

On 4/25/06, Peter N. Lundblad <peter@famlundblad.se> wrote:
> Ivan Zhakov writes:
> > On 4/25/06, Peter N. Lundblad <peter@famlundblad.se> wrote:
> > > Ivan Zhakov writes:
> > > > Hi, Peter!
> > > > It seems Subversion doesn't remove wcprops directory when upgrading WC
> > > > to format 8. Is it right?
> > > >
> > >
> > > Yes, it does, and that should be fixed. I plan to get rid of this and
> > > some other files that has become redundant, but thanks for the
> > > reminder.
> > >
> > Np. I'll do it. I have mostly working patch already.
> >
> Great!
>
Peter,
What do you think about this patch:
[[
Remove wcprops directory when upgrade WC to format 8.

* subversion/libsvn_wc/lock.c
  (convert_wcprops): Add log commands to remove wcprops directory and
  dir-wcprops file.
* subversion/libsvn_wc/log.c
  (log_do_rm): Add option for removing directory.
  (start_handler): Process 'rm-dir' log command.
  (svn_wc__loggy_remove_dir): New function.
  (svn_wc__loggy_remove_file): Rename from svn_wc__loggy_remove.
  (loggy_move_copy_internal): Call svn_wc__loggy_remove_file instead of
  svn_wc__loggy_remove.

* subversion/libsvn_wc/log.h
  (svn_wc__loggy_remove_file): Rename from svn_wc__loggy_remove.
  (svn_wc__loggy_remove_dir): New function declaration.

* subversion/libsvn_wc/adm_ops.c
* subversion/libsvn_wc/props.c
* subversion/libsvn_wc/update_editor.c
  Update callers to svn_wc__loggy_remove_file instead of
  svn_wc__loggy_remove.
]]

--
Ivan Zhakov


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Wed Apr 26 14:15:19 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.