[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] small clarity fix for vdelta implementation

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: 2006-04-26 13:53:38 CEST

Sorry for responding after a week. Thought that post did not recieve any
attention.
No current_match_len can be either '0' or greater than or equal to
VD_KEY_SIZE
current_match_len = match_len (This code is inside a block where
match_len is >=VD_KEY_SIZE)

So
- if (current_match_len < VD_KEY_SIZE)
+ if (!current_match_len)

With regards
Kamesh Jayachandran
Branko ÄŒibej wrote:
> Kamesh Jayachandran wrote:
>> Hi All,
>> Trying to understand the vdelta implementation in subversion.
>> I have the following clarity suggestion to the code.
>> In the vdelta(): current_match_len can either be 0 or >= to VD_KEY_SIZE.
>> The 'no-match check' of (current_match_len < VD_KEY_SIZE) can be
>> simplified to
>> (!current_match_len) for clarity.
> IIRC, the match _can_ be shorter than the key size. at least, you can
> see shorter "new" and "copy" instructions in the delta.
>
> I can't tell without looking at more of the vdelta code, which I can't
> do right now.
>
> -- Brane
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 26 13:53:31 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.