-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hyrum K. Wright wrote:
> (Sent from wrong email address, resending...)
>
> As of r18363, we now include zlib unconditionally. The check against
> SVN_HAVE_ZLIB in libsvn_subr/stream.c is now redundant, because we are
> guaranteed to have zlib available. This patch removes this check, and
> also changes the behavior of svn_stream_compressed to always return the
> compressed stream, instead of defaulting to the uncompressed version.
>
> This patch does not remove the SVN_HAVE_ZLIB define, but it would appear
> that this is also redundant.
>
> -Hyrum
>
> [[[
> Remove #ifdef checks for SVN_HAVE_ZLIB in stream.c. As of r18363, we
> now link zlib in unconditionally.
>
> * subversion/libsvn_subr/stream.c
> Remove check for SVN_HAVE_ZLIB for inclusion of zlib.h.
> Remove check for SVN_HAVE_ZLIB in declaring structures for compressed
> stream support.
>
> (svn_stream_compressed): Remove check for SVN_HAVE_ZLIB. Return the
> compressed stream unconditionally.
> ]]]
Hmm.
svn_stream_compressed() has been a crippled, stupid, no-op in all 1.3.x
and below versions, unless --with-zlib was explicitly passed to
configure. Worse, when it is used for reading, there is no attempt to
be compatible with Subversion instances that are configured the other way.
In other words, the API sucks very much, and I don't think we use it at all.
What's the appropriate thing for us to do here? Just put a large warning
in the doxygen that it is irredeemably buggy in svn less than 1.4.0 ?
Max.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
iD8DBQFERn08fFNSmcDyxYARAljJAKCnmdOscsH3TLkf5mMpYbV4tGh1cwCgxNHJ
wonnOMliaKgnveRfTrxPRLE=
=znPV
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 19 20:13:20 2006