[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17805 - trunk

From: Justin Erenkrantz <justin_at_erenkrantz.com>
Date: 2006-04-18 20:14:14 CEST

On Thu, Dec 15, 2005 at 05:03:09PM -0600, maxb@tigris.org wrote:
> Author: maxb
> Date: Thu Dec 15 17:03:08 2005
> New Revision: 17805
>
> Modified:
> trunk/configure.in
>
> Log:
> * configure.in: If the system has an acceptable install program, then use it,
> rather than the fallback shell script which we were previously using
> unconditionally.
>
>
> Modified: trunk/configure.in
> Url: http://svn.collab.net/viewcvs/svn/trunk/configure.in?rev=17805&p1=trunk/configure.in&p2=trunk/configure.in&r1=17804&r2=17805
> ==============================================================================
> --- trunk/configure.in (original)
> +++ trunk/configure.in Thu Dec 15 17:03:08 2005
> @@ -26,17 +26,6 @@
> AC_SUBST([abs_srcdir], ["`cd $srcdir && pwd`"])
> AC_SUBST([abs_builddir], ["`pwd`"])
>
> -dnl ### should we ever bother with the system install?
> -dnl use abs_srcdir. sometimes during installation, libtool will relink the
> -dnl library. when it does this, it does a "cd", so a relative use of
> -dnl install-sh will not work.
> -INSTALL="$abs_srcdir/build/install-sh -c"
> -AC_SUBST(INSTALL)
> -
> -MKDIR="$INSTALL -d"
> -AC_SUBST(MKDIR)
> -
> -
> dnl Generate config.nice early (before the args are munged)
> SVN_CONFIG_NICE(config.nice)
>
> @@ -52,8 +41,9 @@
> dnl Look for an extended grep, this macro appeared in autoconf-2.53b
> ifdef([AC_PROG_EGREP],[AC_PROG_EGREP],[])
>
> -dnl See if 'ln -s' works
> AC_PROG_LN_S
> +AC_PROG_INSTALL
> +AC_SUBST([MKDIR], ["$INSTALL -d"])
>
> dnl Configure APR --------------------------

-1.

This breaks the build on Solaris with VPATH builds. The comment that you
deleted ("use abs_srcdir...") is the reason why we can't use
AC_PROG_INSTALL. autoconf is not smart enough to understand that we need
the full path to install. Therefore, when we try to install, libtool will
cd to the library directory and attempt to use a bogus relative path of
INSTALL.

Please revert. -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 18 20:18:02 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.