[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r19367 - in trunk/subversion/bindings/swig: include ruby/libsvn_swig_ruby ruby/test

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-04-15 03:46:42 CEST

On 4/14/06, Kouhei Sutou <kou@cozmixng.org> wrote:
> Hi,
>
> In <7edfeeef0604141114i80a124fyd76ec3739402c9fb@mail.gmail.com>
> "Re: svn commit: r19367 - in trunk/subversion/bindings/swig: include ruby/libsvn_swig_ruby ruby/test" on Fri, 14 Apr 2006 11:14:20 -0700,
> "Garrett Rooney" <rooneg@electricjellyfish.net> wrote:
>
> > On 4/14/06, kou@tigris.org <kou@tigris.org> wrote:
> > > Author: kou
> > > Date: Fri Apr 14 03:23:08 2006
> > > New Revision: 19367
> > >
> > > Modified:
> > > trunk/subversion/bindings/swig/include/svn_types.swg
> > > trunk/subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c
> > > trunk/subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.h
> > > trunk/subversion/bindings/swig/ruby/test/test_ra.rb
> > >
> > > Log:
> > > Fix a segmentation fault bug.
> >
> > I would have referred to this particular problem as a GC bug that
> > results in segmentation faults in some cases. When I hear
> > "segmentation fault bug" I think of a NULL pointer dereferrence or
> > something else relatively simple, with this kind of problem just
> > looking at the diff it's pretty difficult to actually tell why what
> > you're doing fixes something, without knowing the fact that it's a GC
> > issue.
>
> What about the following log message?
>
> Fix a segmentation fault bug related Ruby's GC. To fix the
> bug, add a reference to a baton made internally from
> returned Svn::Delta::Editor.

Sounds perfect to me.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Apr 15 03:47:26 2006

This is an archived mail posted to the Subversion Dev mailing list.