Re: The nonxml-entries branch

"Peter N. Lundblad" <peter@famlundblad.se> writes:

[performace figures that look good]

> I strongly feel this branch should be merged and would like some
> review if possible.

I've had a look at the code (not compiled or tested) and it looks good
to me, I think it should be merged. Two comments so far:

  - there is broken indentation around line 1090 in entries.c.

  - when writing the entries perhaps make a guess at the overall size
    (use the number of entries?) and pre-allocate bigstr to avoid some
    of the my_realloc calls.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org