[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: The nonxml-entries branch

From: Branko Čibej <brane_at_xbc.nu>
Date: 2006-04-12 12:21:01 CEST

Peter N. Lundblad wrote:
> Malcolm Rowe writes:
> > On Tue, Apr 11, 2006 at 05:17:40PM -0400, Marc Sherman wrote:
> > > Peter N. Lundblad wrote:
> > > > Why keep the .svn/format file?
> > > >
> > > > A disappointing thing with nonxml-entries is that we keep .svn/format,
> > > What if, instead of moving the format number to the top of .svn/entries,
> > > you got rid of the entries file and moved the pipe-separated entries
> > > content to the bottom of the .svn/format file?
> > >
> >
> > +1. That sounds like a really sensible idea, unless I'm missing something.
> >
>
> Technically, I see no problems implementing this. It just seems a little funny
> to store entries in a file called format. But if people feel comfortable
> with this, it is OK with me.
>
Please *no*.

It's a lot saner to move the format number to the beginning of the
entries file.

The parser can look at the first few (e.g., 5) bytes in the entries file
to discriminate between different format versions:

    * It it sees "<?xml", then it knows that's a working copy as we have
      it now, and that it must look at the format file.
    * If it sees, e.g., "# ver", then it's a new working copy without
      the format file, and the version number determines if the contents
      are XML or not.

So as a first step, I'd propose moving the format number to .svn/entries
and ignoring (but not removing!) .svn/format. The header in the entries
file might look like this:

    # version: 33
    <?xml charset="utf-8">

and .svn/format would contain the same format number. We could do this
for 1.4.

Then, at the next minor release, we could remove the format file, bump
the format number, and for all I care stop using XML in the .svn/entries
file.

But let's *not* rush WC format changes.

Or, to put this a bit more in prespective: if we do decide (vote) to
rush head-over-heels into changing the entries format and removing the
format file, those who vote in favour should be required to subscribe to
the users@ list and handle all the screams.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 12 12:23:39 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.