Ivan Zhakov wrote:
> On 4/12/06, mhagger@tigris.org <mhagger@tigris.org> wrote:
>
>>Author: mhagger
>>Date: Tue Apr 11 22:31:41 2006
>>New Revision: 19317
>>
>>Modified:
>> trunk/subversion/tests/cmdline/svntest/main.py
>>
>>Log:
>>If a test skips, clean up its sandbox.
>>
>>Previously only tests whose converted results indicated a pass had
>>their sandboxes cleaned up.
>>
>>* subversion/tests/cmdline/svntest/main.py (TestRunner.run): Only omit
>> sandbox cleanup for tests that result in a failure (not tests that
>> skip).
>
> I'm not sure that it's right change. It is frequent use-case retry
> last operation by hand or look to working copy, when test failed.
But if a test causes itself to be skipped (by raising an svntest.Skip
exception) then there wouldn't be much call for running it again, would
there? The sandboxes of tests that fail are *not* cleaned up, even
after this commit. (My guess was that the old behavior was an oversight
in the implementation of the skip behavior.)
But I would certainly be happy to restore the old behavior if that is
what people want.
On a related point, if a test is explicitly marked Skip (by being listed
as Skip(test_name, 1)) then it seems superfluous to generate a sandbox
in the first place. (For tests that are skipped by throwing a Skip
exception, on the other hand, it is not so easy to avoid creating a
Sandbox.) So I was thinking of skipping sandbox creation for explicitly
Skipped tests. What do people think of that?
Yours,
Michael
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 12 09:40:08 2006