[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Show] Re: svn commit: r19299 - branches/nonxml-entries/subversion/libsvn_wc

From: Julian Reschke <julian.reschke_at_gmx.de>
Date: 2006-04-11 09:02:00 CEST

Peter N. Lundblad wrote:
> Jonathan Gilbert writes:
> > At 10:52 PM 10/04/2006 +0100, Malcolm Rowe wrote:
> > >Hi Peter,
> > >
> > >Random review comments, hope you don't mind.
> > >
> > [snip]
> > >> The entries file
> > >> ----------------
> > >>
> > >> +
> > >> +The characters "|", "\" and ASCII control characters (0x01 - 0x31 and
> > >> +0x7f) must be escaped when they occur in a field. The escaping uses
> >
> > I sure hope nobody goes and commits a patch that escapes characters 0x20
> > throuh 0x31. Those characters are: ' ', !, ", #, $, %, &, ', (, ), *, +,
> > ',', -, ., /, 0 and 1. \:\-\)
> >
>
> Ha, nice catch:-) Should be 0x01 - 0x1f, of course:-)
>
> Fixing.

Question: if this contains information that was in XML before, how would
it ever contain ASCII control characters other than CR, LF and TAB?

Best regards, Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 11 09:04:17 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.